Skip to content

Consistency and Accessibility Improvements of the user-related UIs #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmattheis merged 9 commits into from
Jul 26, 2025
Merged

Consistency and Accessibility Improvements of the user-related UIs #815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
db9183d
Improve accessibility of form fields in AddEditUserDialog
martinfrancois Jul 23, 2025
e3f2696
Remove `type="email"` from username field in AddEditUserDialog
martinfrancois Jul 23, 2025
fc84fb3
Make wording of form fields in AddEditUserDialog consistent with the …
martinfrancois Jul 23, 2025
956d902
Improve accessibility of form fields in Register
martinfrancois Jul 23, 2025
d5ab795
Remove `type="email"` from username field in Register
martinfrancois Jul 23, 2025
eb811e3
Make wording of form fields in Register consistent with the login
martinfrancois Jul 23, 2025
97ea32e
Make wording of form fields in Users consistent with the login
martinfrancois Jul 23, 2025
9f3bbd8
Improve accessibility of form fields in Login
martinfrancois Jul 23, 2025
629271f
Add autocomplete fields to registration
martinfrancois Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ui/src/user/AddEditUserDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,10 @@ export default class AddEditDialog extends Component<IProps, IState> {
autoFocus
margin="dense"
className="name"
label="Name *"
type="email"
label="Username *"
value={name}
name="username"
id="username"
onChange={this.handleChange.bind(this, 'name')}
fullWidth
/>
Expand All @@ -65,7 +66,9 @@ export default class AddEditDialog extends Component<IProps, IState> {
type="password"
value={pass}
fullWidth
label={isEdit ? 'Pass (empty if no change)' : 'Pass *'}
label={isEdit ? 'Password (empty if no change)' : 'Password *'}
name="password"
id="password"
onChange={this.handleChange.bind(this, 'pass')}
/>
<FormControlLabel
Expand All @@ -89,7 +92,7 @@ export default class AddEditDialog extends Component<IProps, IState> {
? passPresent
? ''
: 'password is required'
: 'name is required'
: 'username is required'
}>
<div>
<Button
Expand Down
4 changes: 4 additions & 0 deletions ui/src/user/Login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,21 @@ class Login extends Component<Stores<'currentUser'>> {
<form onSubmit={this.preventDefault} id="login-form">
<TextField
autoFocus
id="username"
className="name"
label="Username"
name="username"
Comment thread
jmattheis marked this conversation as resolved.
margin="dense"
autoComplete="username"
value={username}
onChange={(e) => (this.username = e.target.value)}
/>
<TextField
id="password"
type="password"
className="password"
label="Password"
name="password"
margin="normal"
autoComplete="current-password"
value={password}
Expand Down
13 changes: 9 additions & 4 deletions ui/src/user/Register.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,21 +46,26 @@ export default class RegistrationDialog extends Component<IProps, IState> {
<DialogContent>
<TextField
autoFocus
id="register-username"
margin="dense"
className="name"
label="Name *"
type="email"
label="Username *"
name="username"
value={name}
autoComplete="username"
onChange={this.handleChange.bind(this, 'name')}
fullWidth
/>
<TextField
id="register-password"
margin="dense"
className="password"
type="password"
value={pass}
fullWidth
label="Pass *"
label="Password *"
name="password"
autoComplete="new-password"
onChange={this.handleChange.bind(this, 'pass')}
/>
</DialogContent>
Expand All @@ -73,7 +78,7 @@ export default class RegistrationDialog extends Component<IProps, IState> {
? passPresent
? ''
: 'password is required'
: 'name is required'
: 'username is required'
}>
<div>
<Button
Expand Down
2 changes: 1 addition & 1 deletion ui/src/user/Users.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class Users extends Component<WithStyles<'wrapper'> & Stores<'userStore'>> {
<Table id="user-table">
<TableHead>
<TableRow style={{textAlign: 'center'}}>
<TableCell>Name</TableCell>
<TableCell>Username</TableCell>
<TableCell>Admin</TableCell>
<TableCell />
</TableRow>
Expand Down
Loading