LED 93 account application boundary cleanup

.agents/skills/ledgerly-architecture-docs/SKILL.md

@@ -14,7 +14,7 @@ Use this skill when the user asks to:
 
 - create or update ADRs;
 - add architectural decision rationale to task docs;
-- link Jira/PR to architecture docs;
+- link Jira tasks to architecture docs;
 - archive completed plan documents;
 - replace obsolete decisions and mark superseded status.
 
@@ -52,7 +52,10 @@ Every ADR should include:
 - `Status: Proposed|Accepted|Superseded|Deprecated`
 - `Date: YYYY-MM-DD`
 - `Jira: <link-or-N/A>`
-- `PR: <link-or-TBD>`
+
+ADR files should not include PR metadata. If a branch reference is useful while
+work is in progress, add it under `Related` instead of making it a required
+metadata field.
 
 ### Minimum ADR sections
 
@@ -71,7 +74,7 @@ Keep each section concise and decision-focused.
 3. Preserve historical facts; do not rewrite accepted history to match new intent.
 4. If direction changed, create new ADR and mark old one as `Superseded`.
 5. Keep links stable; when moving plan docs to archive, update ADR links.
-6. Prefer explicit links to Jira issue and PR once available.
+6. Prefer explicit links to Jira issues; avoid PR metadata in ADR front matter.
 7. When updating docs alongside code, keep the doc change scoped to the same
    Jira task and explain the code/docs relationship in the final response.
 
@@ -93,8 +96,8 @@ For task documents in `docs/plans/`:
 2. Create `NNNN-*.md` with required metadata and sections.
 3. Add concise rationale and rejected alternatives.
 4. Update ADR index in `docs/architecture/adr/README.md`.
-5. Add Jira immediately; fill PR as `TBD` if not created.
-6. After PR creation, replace `PR: TBD` with actual link.
+5. Add Jira immediately. Optionally mention the implementation branch in
+   `Related` while work is in progress.
 
 ### Supersede an ADR
 
@@ -107,7 +110,7 @@ For task documents in `docs/plans/`:
 ### Finalize completed task docs
 
 1. Verify all checklist items are complete.
-2. Add/verify Jira and PR references.
+2. Add/verify Jira references.
 3. Move completed plan to archive if team follows archive policy.
 4. Update links in ADR and any docs that referenced old path.
 
@@ -132,7 +135,6 @@ Before finalizing documentation changes, confirm:
 - Status: Proposed|Accepted|Superseded|Deprecated
 - Date: YYYY-MM-DD
 - Jira: <link-or-N/A>
-- PR: <link-or-TBD>
 
 ## Context
 
@@ -160,7 +162,6 @@ Before finalizing documentation changes, confirm:
 ```md
 Статус документа: выполнено.
 
-- [x] Связать этот документ с Jira-задачей и итоговым pull request.
+- [x] Связать этот документ с Jira-задачей.
       Jira: <link>
-      PR: <link>
 ```

apps/backend/drizzle/0000_nostalgic_ben_parker.sql

@@ -1,12 +1,9 @@
 CREATE TABLE `accounts` (
 	`commodity_id` text NOT NULL,
 	`created_at` text NOT NULL,
-	`current_cleared_balance_local` text NOT NULL,
 	`description` text NOT NULL,
 	`id` text PRIMARY KEY NOT NULL,
-	`initial_balance` text NOT NULL,
 	`is_closed` integer NOT NULL,
-	`is_system` integer NOT NULL,
 	`is_tombstone` integer NOT NULL,
 	`name` text NOT NULL,
 	`type` text NOT NULL,
@@ -41,7 +38,6 @@ CREATE TABLE `operations` (
 	`created_at` text NOT NULL,
 	`description` text NOT NULL,
 	`id` text PRIMARY KEY NOT NULL,
-	`is_system` integer NOT NULL,
 	`is_tombstone` integer NOT NULL,
 	`transaction_id` text NOT NULL,
 	`updated_at` text NOT NULL,
@@ -87,4 +83,4 @@ CREATE TABLE `commodities` (
 );
 --> statement-breakpoint
 CREATE UNIQUE INDEX `commodities_user_id_code_unique_idx` ON `commodities` (`user_id`,`code`);--> statement-breakpoint
-CREATE UNIQUE INDEX `commodities_user_id_id_unique_idx` ON `commodities` (`user_id`,`id`);
+CREATE UNIQUE INDEX `commodities_user_id_id_unique_idx` ON `commodities` (`user_id`,`id`);

apps/backend/drizzle/meta/0000_snapshot.json

@@ -21,13 +21,6 @@
           "notNull": true,
           "autoincrement": false
         },
-        "current_cleared_balance_local": {
-          "name": "current_cleared_balance_local",
-          "type": "text",
-          "primaryKey": false,
-          "notNull": true,
-          "autoincrement": false
-        },
         "description": {
           "name": "description",
           "type": "text",
@@ -42,27 +35,13 @@
           "notNull": true,
           "autoincrement": false
         },
-        "initial_balance": {
-          "name": "initial_balance",
-          "type": "text",
-          "primaryKey": false,
-          "notNull": true,
-          "autoincrement": false
-        },
         "is_closed": {
           "name": "is_closed",
           "type": "integer",
           "primaryKey": false,
           "notNull": true,
           "autoincrement": false
         },
-        "is_system": {
-          "name": "is_system",
-          "type": "integer",
-          "primaryKey": false,
-          "notNull": true,
-          "autoincrement": false
-        },
         "is_tombstone": {
           "name": "is_tombstone",
           "type": "integer",
@@ -315,13 +294,6 @@
           "notNull": true,
           "autoincrement": false
         },
-        "is_system": {
-          "name": "is_system",
-          "type": "integer",
-          "primaryKey": false,
-          "notNull": true,
-          "autoincrement": false
-        },
         "is_tombstone": {
           "name": "is_tombstone",
           "type": "integer",
@@ -657,4 +629,4 @@
   "internal": {
     "indexes": {}
   }
-}
+}

apps/backend/src/__tests__/user/user.service.test.ts

@@ -1,8 +1,8 @@
 import {
+  EntityAlreadyExistsError,
   InvalidPasswordError,
-  UserAlreadyExistsError,
   UserNotFoundError,
-} from 'src/application/application.errors';
+} from 'src/application';
 import { Id } from 'src/domain/domain-core';
 import { PasswordManager } from 'src/infrastructure/auth/PasswordManager';
 import { UserRepository } from 'src/infrastructure/db/';
@@ -114,7 +114,7 @@ describe.skip('UserService', () => {
       mockUsersRepository.findByEmail.mockResolvedValue({ id: '1' });
 
       await expect(service.update(nextId, userData)).rejects.toThrowError(
-        UserAlreadyExistsError,
+        EntityAlreadyExistsError,
       );
     });
 

apps/backend/src/application/application.errors.test.ts

@@ -4,10 +4,10 @@ import {
   AuthenticationFailedError,
   CommodityClosedError,
   CommodityHasActiveReferencesError,
+  EntityAlreadyExistsError,
   InvalidPasswordError,
   ApplicationError,
   EntityNotFoundError,
-  UserAlreadyExistsError,
   UserNotFoundError,
 } from 'src/application/application.errors';
 import { describe, expect, it } from 'vitest';
@@ -38,10 +38,18 @@ describe('coded application errors', () => {
     },
   );
 
-  it('uses a stable public code for a registration conflict', () => {
-    expect(new UserAlreadyExistsError()).toMatchObject({
-      code: apiErrorCodes.registrationConflict,
-      context: {},
+  it('uses a stable public code for an entity that already exists', () => {
+    expect(
+      new EntityAlreadyExistsError({
+        entityType: 'user',
+        field: 'email',
+      }),
+    ).toMatchObject({
+      code: apiErrorCodes.entityAlreadyExists,
+      context: {
+        entityType: 'user',
+        field: 'email',
+      },
     });
   });
 

apps/backend/src/application/application.errors.ts

@@ -40,6 +40,19 @@ export class EntityNotFoundError extends CodedApplicationError<'ENTITY_NOT_FOUND
   }
 }
 
+/**
+ * Thrown when an entity violates a public uniqueness contract.
+ */
+export class EntityAlreadyExistsError extends CodedApplicationError<'ENTITY_ALREADY_EXISTS'> {
+  constructor(context: ErrorContextByCode['ENTITY_ALREADY_EXISTS']) {
+    super(
+      `${context.entityType} already exists for ${context.field}`,
+      apiErrorCodes.entityAlreadyExists,
+      context,
+    );
+  }
+}
+
 /**
  * Thrown when a user attempts to access an entity they don't own.
  */
@@ -131,15 +144,6 @@ export class InvalidPasswordError extends AuthenticationFailedError {
   }
 }
 
-/**
- * Thrown when trying to register a user that already exists.
- */
-export class UserAlreadyExistsError extends CodedApplicationError<'REGISTRATION_CONFLICT'> {
-  constructor(message = 'User already exists') {
-    super(message, apiErrorCodes.registrationConflict, {});
-  }
-}
-
 /**
  * Thrown when an update cannot be applied because aggregate versions differ.
  */

apps/backend/src/application/interfaces/AccountRepository.interface.ts

@@ -3,9 +3,7 @@ import { AccountQuery } from '@ledgerly/shared/validation';
 import { AccountSnapshot } from 'src/domain/accounts';
 
 export type AccountRepositoryUpdateInput = Pick<AccountSnapshot, 'updatedAt'> &
-  Partial<
-    Pick<AccountSnapshot, 'description' | 'initialBalance' | 'name' | 'type'>
-  >;
+  Partial<Pick<AccountSnapshot, 'description' | 'name' | 'type'>>;
 
 export type AccountRepositoryLifecycleInput = { updatedAt: IsoDatetimeString };
 

apps/backend/src/application/mappers/account.mapper.test.ts

@@ -1,6 +1,6 @@
 import { AccountUpdateDTO } from '@ledgerly/shared/types';
 import { AccountSnapshot } from 'src/domain/accounts';
-import { Amount, Id, Timestamp } from 'src/domain/domain-core';
+import { Id, Timestamp } from 'src/domain/domain-core';
 import { describe, expect, it } from 'vitest';
 
 import { AccountMapper } from './account.mapper';
@@ -9,12 +9,9 @@ describe('AccountMapper', () => {
   const snapshot: AccountSnapshot = {
     commodityId: Id.create().valueOf(),
     createdAt: Timestamp.create().valueOf(),
-    currentClearedBalanceLocal: Amount.create('2500').valueOf(),
     description: 'Operating account',
     id: Id.create().valueOf(),
-    initialBalance: Amount.create('1000').valueOf(),
     isClosed: false,
-    isSystem: true,
     isTombstone: false,
     name: 'Primary Checking',
     type: 'asset',
@@ -26,12 +23,9 @@ describe('AccountMapper', () => {
     expect(AccountMapper.toResponseDTOFromSnapshot(snapshot)).toEqual({
       commodityId: snapshot.commodityId,
       createdAt: snapshot.createdAt,
-      currentClearedBalanceLocal: snapshot.currentClearedBalanceLocal,
       description: snapshot.description,
       id: snapshot.id,
-      initialBalance: snapshot.initialBalance,
       isClosed: snapshot.isClosed,
-      isSystem: snapshot.isSystem,
       isTombstone: snapshot.isTombstone,
       name: snapshot.name,
       type: snapshot.type,

apps/backend/src/application/mappers/account.mapper.ts

@@ -9,7 +9,7 @@ import {
   AccountUpdateProps,
   CreateAccountProps,
 } from 'src/domain/accounts';
-import { Amount, Id, Name } from 'src/domain/domain-core';
+import { Id, Name } from 'src/domain/domain-core';
 
 export class AccountMapper {
   static toResponseDTOFromSnapshot(
@@ -18,12 +18,9 @@ export class AccountMapper {
     return {
       commodityId: snapshot.commodityId,
       createdAt: snapshot.createdAt,
-      currentClearedBalanceLocal: snapshot.currentClearedBalanceLocal,
       description: snapshot.description,
       id: snapshot.id,
-      initialBalance: snapshot.initialBalance,
       isClosed: snapshot.isClosed,
-      isSystem: snapshot.isSystem,
       isTombstone: snapshot.isTombstone,
       name: snapshot.name,
       type: snapshot.type,
@@ -35,7 +32,6 @@ export class AccountMapper {
     return {
       commodityId: Id.restore(dto.commodityId),
       description: dto.description,
-      initialBalance: Amount.create(dto.initialBalance),
       name: Name.create(dto.name),
       type: AccountType.create(dto.type),
     };

apps/backend/src/application/mappers/operation.mapper.ts

@@ -35,7 +35,6 @@ export class OperationMapper {
       createdAt: snapshot.createdAt,
       description: snapshot.description,
       id: snapshot.id,
-      isSystem: snapshot.isSystem,
       transactionId: snapshot.transactionId,
       updatedAt: snapshot.updatedAt,
       userId: snapshot.userId,

apps/backend/src/application/mappers/transaction-read-model-response.mapper.ts

@@ -30,7 +30,6 @@ export class TransactionReadModelResponseMapper {
       createdAt: operation.createdAt,
       description: operation.description,
       id: operation.id,
-      isSystem: operation.isSystem,
       transactionId: operation.transactionId,
       updatedAt: operation.updatedAt,
       userId: operation.userId,

apps/backend/src/application/mappers/transaction.mapper.test.ts

@@ -74,7 +74,6 @@ describe('TransactionMapper', () => {
           createdAt: activeOperation.createdAt,
           description: activeOperation.description,
           id: activeOperation.id,
-          isSystem: activeOperation.isSystem,
           transactionId: activeOperation.transactionId,
           updatedAt: activeOperation.updatedAt,
           userId: activeOperation.userId,

apps/backend/src/application/read-models/transaction.read-model.ts

@@ -11,7 +11,6 @@ export type OperationReadModel = {
   createdAt: IsoDatetimeString;
   description: string;
   id: UUID;
-  isSystem: boolean;
   transactionId: UUID;
   updatedAt: IsoDatetimeString;
   userId: UUID;