feat: initialize LSP clients before requests#3324
Draft
aofei wants to merge 1 commit into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Send the LSP `initialize` request before ordinary client requests and follow it with the `initialized` notification after the server accepts the handshake. This declares the editor capabilities the client consumes and gates requests until the server is ready. Thread the UI locale into the initialization params and align JSON-RPC IDs with the LSP `MessageID` shape used by request and response messages. Updates goplus/xgolsw#329 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send the LSP
initializerequest before ordinary client requests and follow it with theinitializednotification after the server accepts the handshake. This declares the editor capabilities the client consumes and gates requests until the server is ready.Thread the UI locale into the initialization params and align JSON-RPC IDs with the LSP
MessageIDshape used by request and response messages.Updates goplus/xgolsw#329