feat(server)!: the endpoint complete campaigns is switched to the post method#3224
Conversation
|
For backwards compatibility, I think we should support Then, the release notes for an upcoming release we could say that the Also, if you could please remove the minified JS files, it'd be appreciated! We'll build those ourselves since they're tough to review. |
|
I will be making the corresponding changes 🫡 |
3097a88 to
f34d940
Compare
This should be enough 😊 @jordan-wright |
… is switched to the post method)
… is switched to the post method)
Reason
Solve problem 3117 which is to change the endpoint from GET to POST of the route that completes the campaign
Changes
controllers/api/campaign.go: Changed the enpoint method from POST to GET incampaigns/{id:[0-9]+}/completestatic/js/src/app/gophish.js: Changed the enpoint method from POST to GET inquery("/campaigns/" + id + "/complete", "POST", {}, true)Compiled the corresponding JavaScript with Gulp (static/js/dist/app/autocomplete.min.js, static/js/dist/app/campaign_results.min.js, static/js/dist/app/settings.min.js...)