Repository navigation
fix(export): return errors from configuration writes - #224
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
DumpTo now returns the writer's error with its byte count. WriteTo and DumpToFile inherit that behavior.
Previously, failed or partial writes returned nil, so configuration exports appeared successful.
Eight regression cases check errors at zero, partial and full byte counts, plus successful output.
They also check error identity and the output newline. Six cases fail against the original implementation.
The full
go test -race -coverprofile=profile.cov ./...suite passes on Go 1.21.13 and 1.23.4.go build ./...,go vet ./...andgo mod verifypass.Staticcheck reports the same 190 existing findings as unchanged master. Revive reports the same 15 existing warnings.