add a %%shell exit-builtin regression test#6022
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_929401511
branch
from
47263c5 to
2362ea0
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_929401511
branch
from
2362ea0 to
cfd1cc7
Compare
cover the case where a %%shell cell runs the bash `exit` builtin with a non-zero status, so a non-zero return code from a shell builtin still propagates as an error. the prior test only exercised an external command. PiperOrigin-RevId: 931275126
copybara-service
Bot
force-pushed
the
test_929401511
branch
from
cfd1cc7 to
1127423
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a %%shell exit-builtin regression test
cover the case where a %%shell cell runs the bash
exitbuiltin with anon-zero status, so a non-zero return code from a shell builtin still
propagates as an error. the prior test only exercised an external command.