Skip to content

refactor(api): split xref_test.go by domain - #7760

Merged
coryan merged 1 commit into
googleapis:mainfrom
coryan:split-xref-by-domain
Oct 6, 2026
Merged

coryan merged 1 commit into
googleapis:mainfrom
coryan:split-xref-by-domain

Conversation

@coryan

@coryan coryan commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Towards #7722

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the test suite in xref_test.go by splitting its large volume of test cases into smaller, dedicated test files: xref_aip_test.go, xref_lookup_test.go, xref_method_test.go, and xref_samples_test.go. This reorganization improves maintainability and readability. There are no review comments to assess, and I have no feedback to provide.

@coryan
coryan marked this pull request as ready for review October 6, 2026 14:11
@coryan
coryan requested review from a team as code owners October 6, 2026 14:11
@coryan
coryan merged commit 48c0833 into googleapis:main Oct 6, 2026
47 of 48 checks passed
@coryan
coryan deleted the split-xref-by-domain branch October 6, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants