Repository navigation
test(sample): use NewTest* in remaining models - #7758
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors internal/sample/api.go to use a builder-style API (such as api.NewTestEnum, api.NewTestMessage, and api.NewTestField) for constructing sample API structures instead of direct struct initializations. The feedback points out a redundant WithID call in SecretPayload because WithPackage already sets the ID.
coryan
marked this pull request as ready for review
October 6, 2026 12:08
nolanleastin
approved these changes
Oct 6, 2026
coryan
force-pushed
the
newtest-pr15-sample-models
branch
from
October 6, 2026 16:57
96fff16 to
15b364a
Compare
coryan
enabled auto-merge (squash)
October 6, 2026 16:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #7722