feat: Remove the verifySubscription() function when starting CPS source connector - #384
feat: Remove the verifySubscription() function when starting CPS source connector#384rQ-Qrr wants to merge 1 commit into
Conversation
matt-kwong
left a comment
There was a problem hiding this comment.
Please update the commit message to follow the convention.
The change makes sense to me. Could you include a before and after of how the connector handles a non-existent subscription on startup?
318af49 to
bf31308
Compare
Sure, updated.
Before, if the subscription doesn't exist, when creating the CPS source connector, it will return an error After this change, it still returns an error |
We actually do want the connector to go into a Failed state if it subscribing from a CPS Subscription returns NotFound. A NotFound error like this requires user intervention. PTAL The only reason we're removing the check at startup is to reduce the number of permissions required to run the connector - just |
Fixes #383 ☕️