feat(storage)!: retry loop for downloads - #469
Merged
Merged
Conversation
coryan
reviewed
Aug 18, 2026
coryan
left a comment
Contributor
There was a problem hiding this comment.
Nothing blocking, though maybe the behavior when the service returns more data than expected should be to return an error?
coryan
approved these changes
Aug 18, 2026
chingor13
marked this pull request as ready for review
August 18, 2026 23:05
chingor13
enabled auto-merge (squash)
August 18, 2026 23:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements retry loop for download
The metadata is returned on the initial request so we want this part of the retry loop. Therefore, we change when the user calls
await.Metadata reading:
Data reading:
Since the metadata fetching and data stream are in the same request, we use a coordinator to manage the RPC call.