feat(storage)!: return stream of ByteBuffer - #463
Merged
Conversation
create internal type to wrap AsyncHttpClient body type skip checksumming for now remove checksumming stuff for now
chingor13
changed the title
chingor13
changed the title
chingor13
marked this pull request as ready for review
August 17, 2026 23:10
chingor13
changed the title
coryan
approved these changes
Aug 18, 2026
coryan
left a comment
coryan
left a comment
Contributor
There was a problem hiding this comment.
I think we will want a different return type for the stream, but this is an improvement we should merge as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #462
We now return an iterator of
SwiftNIO.ByteBufferrather thanData. This makes it so we don't need to make copies of data while converting between types.