Fix coverage - #17952
Conversation
There was a problem hiding this comment.
Code Review
This pull request primarily performs bulk version bumps and changelog updates across numerous Google Cloud Python packages. Additionally, it modifies ci/run_conditional_tests.sh to defer the git clone redirection configuration until after git fetch origin is executed, preventing Git from intercepting the fetch command. Feedback on this change suggests using --replace-all and --add flags for the git config commands to ensure multiple insteadOf patterns are correctly registered without overwriting each other or failing on persistent runners.
| git config --global url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python" | ||
| git config --global url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python.git" |
There was a problem hiding this comment.
When configuring multiple insteadOf values for the same key, subsequent git config commands without the --add option will overwrite the previous values rather than appending them. Additionally, if the script is run multiple times on a persistent runner, git config may fail with an error indicating that the key has multiple values.
To ensure both patterns are correctly registered and to avoid potential errors, use --replace-all for the first entry and --add for the subsequent entries.
| git config --global url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python" | |
| git config --global url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python.git" | |
| git config --global --replace-all url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python" | |
| git config --global --add url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python.git" |
No description provided.