Skip to content

Fix coverage - #17952

Closed
parthea wants to merge 4 commits into
mainfrom
fix-coverage-2
Closed

Fix coverage#17952
parthea wants to merge 4 commits into
mainfrom
fix-coverage-2

Conversation

@parthea

@parthea parthea commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily performs bulk version bumps and changelog updates across numerous Google Cloud Python packages. Additionally, it modifies ci/run_conditional_tests.sh to defer the git clone redirection configuration until after git fetch origin is executed, preventing Git from intercepting the fetch command. Feedback on this change suggests using --replace-all and --add flags for the git config commands to ensure multiple insteadOf patterns are correctly registered without overwriting each other or failing on persistent runners.

Comment on lines +72 to +73
git config --global url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python"
git config --global url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python.git"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

When configuring multiple insteadOf values for the same key, subsequent git config commands without the --add option will overwrite the previous values rather than appending them. Additionally, if the script is run multiple times on a persistent runner, git config may fail with an error indicating that the key has multiple values.

To ensure both patterns are correctly registered and to avoid potential errors, use --replace-all for the first entry and --add for the subsequent entries.

Suggested change
git config --global url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python"
git config --global url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python.git"
git config --global --replace-all url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python"
git config --global --add url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python.git"

@parthea parthea closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant