Skip to content

chore: update to librarian v0.31.2-0.20260730143954-e9da697881de - #17945

Open
parthea wants to merge 1 commit into
mainfrom
chore-update-librarian-2026-07-30
Open

chore: update to librarian v0.31.2-0.20260730143954-e9da697881de#17945
parthea wants to merge 1 commit into
mainfrom
chore-update-librarian-2026-07-30

Conversation

@parthea

@parthea parthea commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

This pull request bumps the Librarian version to v0.31.2-0.20260730143954-e9da697881de

All of the changes in 3f323c8 were created by this command

docker run -u $(id -u):$(id -g) -v .:/repo -v ~/.cache:/.cache -w /repo docker.io/library/librarian-python:e9da697881de7de6ebf9e5b17ef6704a4c0dbc52 generate -v --all

# limitations under the License.

# Generated by the protocol buffer compiler. DO NOT EDIT!
# NO CHECKED-IN PROTOBUF GENCODE

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok for google-cloud-python. Historically, we have been checking in gencode and will continue to do so.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates generated protocol buffer files across multiple packages to support Protobuf Python Version 6.33.5 (upgraded from 4.25.3). The changes include adding runtime version validation, replacing deprecated _options with _loaded_options, updating boolean descriptor checks to use pythonic not, and modernizing type annotations in .pyi files (such as using collections.abc for Iterable and Mapping, and adding datetime support). Additionally, test configurations have been updated to include the new edition field. There are no review comments, and we have no feedback to provide.

@parthea
parthea marked this pull request as ready for review July 30, 2026 16:01
@parthea
parthea requested review from a team as code owners July 30, 2026 16:01
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant