Skip to content

for testing purposes - #17941

Closed
parthea wants to merge 2 commits into
mainfrom
testing-librarian-protoc
Closed

for testing purposes#17941
parthea wants to merge 2 commits into
mainfrom
testing-librarian-protoc

Conversation

@parthea

@parthea parthea commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

This PR was created using a version of librarian with protoc 33.5 : googleapis/librarian#7139

This includes the changes from #17743

@parthea
parthea changed the base branch from require-protobuf-6-33-5 to main July 30, 2026 14:43

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the generated protocol buffer files across multiple Google Cloud packages to Protobuf Python Version 6.33.5. The changes introduce runtime version validation, update descriptor option lookups to use _loaded_options instead of _options, and modernize type annotations in .pyi stub files (such as utilizing collections.abc and supporting native datetime types). Additionally, test configurations are updated to include the new edition field. I have no feedback to provide as there are no review comments.

@parthea parthea closed this Jul 30, 2026
@parthea parthea reopened this Jul 30, 2026
@parthea parthea closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant