feat(sqlalchemy-spanner): export MAX_SIZE constant - #17922
Merged
Conversation
….max_size attribute
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request exposes the MAX_SIZE constant from the sqlalchemy_spanner module, making it publicly accessible and integrating it into the SpannerDialect class. It also adds a unit test to verify the export and the behavior of the int_from_size helper function. There are no review comments, so I have no feedback to provide.
olavloite
approved these changes
Jul 30, 2026
| } | ||
|
|
||
| _max_size = 2621440 | ||
| MAX_SIZE = 2621440 |
Contributor
There was a problem hiding this comment.
nit: should we consider renaming this to MAX_STRING_COLUMN_LENGTH? Or is the MAX_SIZE name a standard in SQLAlchemy? If we keep the name MAX_SIZE, can we add a docstring that explains what this max is for?
sakthivelmanii
enabled auto-merge (squash)
July 30, 2026 09:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promoting _max_size to public MAX_SIZE (and dialect.max_size) allows cross-dialect applications to inspect Spanner's STRING(MAX) limit through the public API. It eliminates private symbol imports while preserving full backward compatibility for existing code.