fix(ci): increase import profiler absolute threshold - #17779
fix(ci): increase import profiler absolute threshold #17779hebaalazzeh wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request increases the --fail-threshold value from 5000 to 120000 in ci/run_single_test.sh when executing the profiler script. The feedback suggests double-quoting the ${PROFILER_SCRIPT} and ${PACKAGE_NAME} variables to prevent potential word splitting and globbing issues.
2e75bfa to
0b2d9fd
Compare
37448ee to
99f6a31
Compare
99f6a31 to
c13a5e7
Compare
parthea
left a comment
There was a problem hiding this comment.
Can you create an example PR which includes changes to packages so we can see the results? Right now we only see No packages assigned to Shard 0. which is expected, but it would be great to see an example
see: #17936 |
This PR implements static matrix sharding for the
import-profilerworkflow to run modified packages in parallel across 8 shards, and sets the absolute failure/timeout threshold for each package import check to120s(2 minutes).Key Changes
.github/workflows/import-profiler.ymlto split modified package execution across 8 GHA runner shards using basic bash modulo logic.all-import-profilesstatus check that acts as the single required GitHub check.ci/run_single_test.shto120000ms(120 seconds / 2 minutes).