fix: require Protobuf 6.33.5+ - #17743
Open
parthea wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the minimum protobuf version requirement to 6.33.5 across multiple packages and configuration files. It also removes support for the 'cpp' protobuf implementation and cleans up associated test configurations and legacy logic. A review comment suggests removing a redundant parameterized test case in packages/google-api-core/noxfile.py to improve code cleanliness.
parthea
force-pushed
the
require-protobuf-6-33-5
branch
from
July 17, 2026 18:00
e13937b to
a007839
Compare
parthea
force-pushed
the
require-protobuf-6-33-5
branch
14 times, most recently
from
July 29, 2026 20:34
8686db1 to
392da59
Compare
parthea
force-pushed
the
require-protobuf-6-33-5
branch
from
July 29, 2026 21:53
392da59 to
f92139e
Compare
parthea
marked this pull request as ready for review
July 30, 2026 00:29
parthea
requested review from
chalmerlowe,
daniel-sanche,
hebaalazzeh and
ohmayr
July 30, 2026 01:01
parthea
enabled auto-merge (squash)
July 30, 2026 01:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards b/420641246
This PR is similar to #17349 for the generator/auto-generated code.
The minimum versions of google-api-core and proto-plus and others also need to be versions that support Protobuf 6
https://github.com/googleapis/python-api-core/releases/tag/v2.24.2
https://github.com/googleapis/proto-plus-python/releases/tag/v1.26.1
Also see the client library versions which allow Protobuf 6.x in PR #13644 (https://github.com/googleapis/google-cloud-python/blob/release-please--branches--main--release-notes/release-notes.md)
Once this PR is merged, I will update
protochere to33.5so we can updategencode: https://github.com/googleapis/librarian/blob/fa34184d746948b1da7df000ffcf832979a3c488/cmd/librarian/Dockerfile#L49