[DRAFT] fix(bigquery): avoid SSLError retry loop#17489
Draft
daniel-sanche wants to merge 7 commits into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request ensures that requests.exceptions.SSLError is not retried during insert_rows_json operations and wraps the exception with a descriptive error message. It also adds corresponding unit and system tests. The feedback suggests wrapping the system test logic in a try...finally block to guarantee that the created table is cleaned up even if assertions fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/391888240
Previously, invalid requests like incorrect table schemas would result in SSLErrors, which would then be retried to the default timeout value. SSLErrors generally won't resolve on retry.
This PR marks SSLErrors as non-retryable, and catches the exception to add clearer error context when involved in an insert_rows operation