tests: fix compatibility with pytest 9.1.0 - #17465
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the generate_tracked_version_test_cases function in test_python_version_support.py to return a list of test parameters instead of yielding them. The review comments correctly point out that several added inline comments are redundant and should be removed to comply with PEP 8 guidelines.
parthea
force-pushed
the
fix-google-api-core-tests
branch
from
June 15, 2026 17:52
2a1c5d0 to
40aefba
Compare
parthea
marked this pull request as ready for review
June 15, 2026 17:53
parthea
force-pushed
the
fix-google-api-core-tests
branch
from
June 15, 2026 17:54
40aefba to
ec20478
Compare
chalmerlowe
approved these changes
Jun 15, 2026
parthea
enabled auto-merge (squash)
June 15, 2026 18:22
chalmerlowe
pushed a commit
that referenced
this pull request
Jun 25, 2026
This PR fixes a compatibility issue with `pytest==9.1.0`. See https://docs.pytest.org/en/stable/deprecations.html#non-collection-iterables-in-pytest-mark-parametrize See the stack trace below which appears without the fix ``` ________________________________________________________________________________________________________ ERROR collecting tests/unit/test_python_version_support.py ________________________________________________________________________________________________________ .nox/97a4db2a/lib/python3.14/site-packages/pluggy/_hooks.py:512: in __call__ return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ .nox/97a4db2a/lib/python3.14/site-packages/pluggy/_manager.py:120: in _hookexec return self._inner_hookexec(hook_name, methods, kwargs, firstresult) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ .nox/97a4db2a/lib/python3.14/site-packages/pluggy/_callers.py:53: in run_old_style_hookwrapper return result.get_result() ^^^^^^^^^^^^^^^^^^^ .nox/97a4db2a/lib/python3.14/site-packages/pytest_asyncio/plugin.py:701: in pytest_pycollect_makeitem_convert_async_functions_to_subclass ) = hook_result.get_result() ^^^^^^^^^^^^^^^^^^^^^^^^ .nox/97a4db2a/lib/python3.14/site-packages/pluggy/_callers.py:38: in run_old_style_hookwrapper res = yield ^^^^^ .nox/97a4db2a/lib/python3.14/site-packages/_pytest/python.py:250: in pytest_pycollect_makeitem return list(collector._genfunctions(name, obj)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ .nox/97a4db2a/lib/python3.14/site-packages/_pytest/python.py:476: in _genfunctions self.ihook.pytest_generate_tests.call_extra(methods, dict(metafunc=metafunc)) .nox/97a4db2a/lib/python3.14/site-packages/pluggy/_hooks.py:573: in call_extra return self._hookexec(self.name, hookimpls, kwargs, firstresult) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ .nox/97a4db2a/lib/python3.14/site-packages/pluggy/_manager.py:120: in _hookexec return self._inner_hookexec(hook_name, methods, kwargs, firstresult) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ .nox/97a4db2a/lib/python3.14/site-packages/_pytest/python.py:124: in pytest_generate_tests metafunc.parametrize(*marker.args, **marker.kwargs, _param_mark=marker) .nox/97a4db2a/lib/python3.14/site-packages/_pytest/python.py:1316: in parametrize argnames, parametersets = ParameterSet._for_parametrize( .nox/97a4db2a/lib/python3.14/site-packages/_pytest/mark/structures.py:203: in _for_parametrize warnings.warn( E pytest.PytestRemovedIn10Warning: Passing a non-Collection iterable to parametrize is deprecated. E Test: tests/unit/test_python_version_support.py::test_all_tracked_versions_and_date_scenarios, argvalues type: generator E Please convert to a list or tuple. E See https://docs.pytest.org/en/stable/deprecations.html#parametrize-iterators ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a compatibility issue with
pytest==9.1.0. See https://docs.pytest.org/en/stable/deprecations.html#non-collection-iterables-in-pytest-mark-parametrizeSee the stack trace below which appears without the fix