Repository navigation
feat(storage): OpenTelemetry client metrics configuration and options - #14484
Open
nidhiii-27 wants to merge 6 commits into
Open
nidhiii-27 wants to merge 6 commits into
nidhiii-27 wants to merge 6 commits into
Conversation
…ions [Generated-by: AI]
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces OpenTelemetry client metrics configuration across GrpcStorageOptions, HttpStorageOptions, and StorageOptions, supported by a new StorageMetricsConfig class and comprehensive unit tests. The review feedback highlights critical issues regarding backward compatibility during deserialization, where the newly added metricInterval field could be null and cause a NullPointerException, and recommends declaring the static resolvers in StorageMetricsConfig as volatile to ensure thread safety during parallel test execution.
nidhiii-27
added this pull request to stack #14485
September 23, 2026 10:36
…rialization [Generated-by: AI]
… options - In GrpcStorageOptions and HttpStorageOptions: - Add null check in getMetricInterval() defaulting to 60 seconds - Use getMetricInterval() in equals() and hashCode() - Update Javadoc for setMeterProvider to document nullable/default behavior - In StorageOptions: - Update Javadoc for setMeterProvider on Builder - In StorageMetricsConfig: - Make sysPropResolver and envResolver volatile for thread safety - In StorageOptionsTest: - Add unit test verifying deserialization with null metricInterval defaults to 60s and equals/hashCode match - Verify explicit client options take precedence over env vars and sysprops [Generated-by: AI]
cpriti-os
requested changes
Oct 7, 2026
cpriti-os
left a comment
cpriti-os
left a comment
Contributor
There was a problem hiding this comment.
Requesting changes mainly for serialization behaviour and the enablement configuration (see inline comments).
[Generated-by: AI]
Format StorageOptions, GrpcStorageOptions, HttpStorageOptions, and StorageOptionsTest using com.spotify.fmt:fmt-maven-plugin:2.25:format under JDK 17 to resolve CI lint check failure. [Generated-by: AI]
cpriti-os
reviewed
Oct 13, 2026
cpriti-os
approved these changes
Oct 13, 2026
cpriti-os
left a comment
cpriti-os
left a comment
Contributor
There was a problem hiding this comment.
LGTM once the getMeterProvider() default behavior below is addressed.
Dhriti07
reviewed
Oct 14, 2026
[Generated-by: AI]
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements Phase 2 (Configuration & Options API) of the OpenTelemetry Client Metrics feature in the Java Cloud Storage SDK (
google-cloud-storage), building on top of PR #14398 (feat/storage-client-metrics-infra).Key Changes
Public Options API (
StorageOptions,GrpcStorageOptions,HttpStorageOptions):isEnableOtelMetrics()(default:false)isEnableOtelDebugMetrics()(default:false)getMeterProvider()returningio.opentelemetry.api.metrics.MeterProvider(fromopentelemetry-api, avoiding leaking SDK implementation types in public API surface)getMetricInterval()(default: 60 seconds)@BetaApi:setEnableOtelMetrics(boolean)setEnableOtelDebugMetrics(boolean)setMeterProvider(MeterProvider)setMetricInterval(Duration)with precondition check requiring positive, non-zero durations.Feature Gates & Environment Variables (
StorageMetricsConfig):com.google.cloud.storage.enable_otel_metricscom.google.cloud.storage.enable_otel_debug_metricsGCP_STORAGE_JAVA_ENABLE_OTEL_METRICS(with fallback toGCP_STORAGE_ENABLE_OTEL_METRICS)GCP_STORAGE_JAVA_ENABLE_OTEL_DEBUG_METRICSfalse).Serialization Resiliency for Distributed Runtimes:
StorageOptionsis serialized across worker nodes:meterProvideras transient.readObject()to reconstitute fromopenTelemetry.getMeterProvider().getMeterProvider(), provided automatic fallback toopenTelemetry.getMeterProvider()whenmeterProvider == null.Testing:
StorageOptionsTest:IllegalArgumentExceptionon null, zero, or negative metric intervals.ByteArrayOutputStream/ObjectInputStream) ensuringgetMeterProvider()remains functional and non-null post-deserialization.[Generated-by: AI]