chore(bigquery-jdbc): fix Dockerfile to install proper dependencies - #13990
Merged
Conversation
logachev
marked this pull request as ready for review
August 4, 2026 20:00
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Dockerfile for java-bigquery-jdbc to install the java-bigquery-jdbc module instead of java-bigquery. However, this change will cause the build to fail because the java-bigquery-jdbc module has been moved out of the google-cloud-java repository. The reviewer suggests explicitly listing the required SDK dependencies from google-cloud-java (such as java-bigquery and java-bigquerystorage) instead of attempting to install the JDBC module from the parent repository.
keshavdandeva
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It used to work when JDBC was residing within BQ, but after it was moved & we got extra SDK dependencies, Dockerfile build got broken.