Skip to content

fix(gax-httpjson): reduce Conscrypt fallback error to debug level - #13962

Merged
lqiu96 merged 2 commits into
mainfrom
pqc-conscrypt-concise-logging
Aug 3, 2026
Merged

fix(gax-httpjson): reduce Conscrypt fallback error to debug level#13962
lqiu96 merged 2 commits into
mainfrom
pqc-conscrypt-concise-logging

Conversation

@lqiu96

@lqiu96 lqiu96 commented Jul 30, 2026

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies HttpJsonConscryptUtils.java to adjust logging behavior when Conscrypt initialization or socket group configuration fails. Specifically, it splits the warning logs to avoid printing full exception stack traces at the WARNING level, instead logging the stack traces at the FINE level. There are no review comments, and the changes look appropriate, so I have no additional feedback to provide.

@lqiu96 lqiu96 changed the title refactor(gax-httpjson): apply concise logging without stacktraces for Conscrypt fallbacks at WARNING level fix(gax-httpjson): reduce Conscrypt fallback error to debug level Jul 30, 2026
@lqiu96
lqiu96 requested a review from blakeli0 July 30, 2026 21:00
@lqiu96
lqiu96 marked this pull request as ready for review July 30, 2026 21:00
@lqiu96
lqiu96 requested review from a team as code owners July 30, 2026 21:00
@lqiu96
lqiu96 enabled auto-merge (squash) July 30, 2026 21:01
@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

@lqiu96
lqiu96 merged commit 8236771 into main Aug 3, 2026
318 of 322 checks passed
@lqiu96
lqiu96 deleted the pqc-conscrypt-concise-logging branch August 3, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants