Skip to content

chore: update executor to fix a SI issue #13492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sakthivelmanii merged 1 commit into from
Jun 16, 2026
Merged

chore: update executor to fix a SI issue #13492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...spanner-executor/src/main/java/com/google/cloud/executor/spanner/CloudClientExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,9 +397,10 @@ public void startRWTransaction() throws Exception {
} else {
transactionOptions.add(Options.isolationLevel(IsolationLevel.SERIALIZABLE));
}
if (optimistic) {
if (!repeatableRead && optimistic) {
transactionOptions.add(Options.readLockMode(ReadLockMode.OPTIMISTIC));
} else {
}
if (repeatableRead && !optimistic) {
transactionOptions.add(Options.readLockMode(ReadLockMode.PESSIMISTIC));
}
Comment on lines +400 to 405

@gemini-code-assist gemini-code-assist Bot Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic for setting the transaction lock mode can be simplified. The default lock mode for read-write transactions in Spanner is PESSIMISTIC. Therefore, you only need to explicitly set the lock mode when OPTIMISTIC is required.

The current implementation has a redundant condition that explicitly sets the PESSIMISTIC lock mode, which is already the default.

You can simplify this block to a single if statement that handles the OPTIMISTIC case, making the code more concise and readable.

Suggested change
if (!repeatableRead && optimistic) {
transactionOptions.add(Options.readLockMode(ReadLockMode.OPTIMISTIC));
} else {
}
if (repeatableRead && !optimistic) {
transactionOptions.add(Options.readLockMode(ReadLockMode.PESSIMISTIC));
}
if (optimistic && !repeatableRead) {
transactionOptions.add(Options.readLockMode(ReadLockMode.OPTIMISTIC));
}

runner =
Expand Down
Loading