chore(spanner): cleanup external host reference - #13426
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames the EXTERNAL_HOST related JDBC URL format and pattern variables to SPANNER_OMNI across the JdbcDriver class and its corresponding tests. The review feedback suggests renaming the test method testJdbcExternalHostFormat to testJdbcSpannerOmniFormat to maintain consistency with these changes.
sakthivelmanii
approved these changes
Jun 11, 2026
olavloite
approved these changes
Jun 11, 2026
sakthivelmanii
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
lqiu96
pushed a commit
that referenced
this pull request
Jun 30, 2026
Cleanup references of EXTERNAL_HOST and uptake SPANNER_OMNI from java-spanner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup references of EXTERNAL_HOST and uptake SPANNER_OMNI from java-spanner