impl(bigtable): only record client schema metric when instance is available - #16409
Merged
scotthart merged 2 commits intoSep 2, 2026
Merged
Conversation
product-auto-label
Bot
added
the
api: bigtable
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates google/cloud/bigtable/data_connection.cc by removing the OpenTelemetry metrics recording block from MakeSingleStubDataConnection and adding an !instances.empty() check before recording metrics in MakeInstanceAffinityDataConnection. I have no additional feedback to provide.
dbolduc
approved these changes
Sep 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16409 +/- ##
==========================================
+ Coverage 92.24% 92.26% +0.02%
==========================================
Files 2246 2246
Lines 212296 212291 -5
==========================================
+ Hits 195825 195872 +47
+ Misses 16471 16419 -52 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy static pool Connection does not require specifying an instance, which makes recording/exporting a client schema metric invalid.