Skip to content

feat(storage): support DirectPath over Interconnect in GCS gRPC - #16408

Open
kalragauri wants to merge 3 commits into
googleapis:mainfrom
kalragauri:feat/dp-gci
Open

feat(storage): support DirectPath over Interconnect in GCS gRPC#16408
kalragauri wants to merge 3 commits into
googleapis:mainfrom
kalragauri:feat/dp-gci

Conversation

@kalragauri

Copy link
Copy Markdown
Contributor

This PR adds support for DirectPath over Interconnect in the Cloud Storage gRPC client library.

Summary of Changes

  • Introduced storage_experimental::DirectPathXdsOverInterconnectOptionand support for the GOOGLE_CLOUD_ENABLE_DIRECT_PATH_XDS_OVER_INTERCONNECT environment variable.
  • Configured storage_internal::DefaultOptionsGrpc to resolve target endpoint google-c2p:///storage-direct.googleapis.com?force-xds with authority storage.googleapis.com when enabled, bypassing GCE environment checks.

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Sep 2, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the DirectPathXdsOverInterconnectOption and the corresponding environment variable GOOGLE_CLOUD_ENABLE_DIRECT_PATH_XDS_OVER_INTERCONNECT to allow configuring DirectPath over Interconnect. When enabled, the client targets google-c2p:///storage-direct.googleapis.com?force-xds with standard TLS. Comprehensive unit tests have been added to cover various scenarios and overrides. Feedback is provided regarding a style guide violation where auto is used for a boolean type instead of an explicit bool const declaration.

Comment thread google/cloud/storage/internal/grpc/default_options.cc Outdated
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.26%. Comparing base (6c82dc0) to head (90b473f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16408      +/-   ##
==========================================
+ Coverage   92.25%   92.26%   +0.01%     
==========================================
  Files        2246     2246              
  Lines      212291   212416     +125     
==========================================
+ Hits       195841   195995     +154     
+ Misses      16450    16421      -29     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kalragauri
kalragauri marked this pull request as ready for review September 3, 2026 04:07
@kalragauri
kalragauri requested review from a team as code owners September 3, 2026 04:07
@kalragauri
kalragauri requested a review from v-pratap September 3, 2026 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant