cleanup(storage): fix GCS tracing test on macOS - #16392
Merged
Merged
Conversation
dbolduc
commented
Aug 27, 2026
Member
There was a problem hiding this comment.
Code Review
This pull request updates a unit test in connection_tracing_test.cc to use std::uint64_t instead of std::size_t for the OTelAttribute type when checking the gl-cpp.initial-read-ranges.ranges-count attribute. There are no review comments, and I have no additional feedback to provide.
dbolduc
marked this pull request as ready for review
August 27, 2026 16:53
dbolduc
enabled auto-merge (squash)
August 27, 2026 16:53
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16392 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 2246 2246
Lines 212035 212035
=======================================
Hits 195598 195598
Misses 16437 16437 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
scotthart
approved these changes
Aug 27, 2026
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.