Skip to content

impl(bigtable): add option to select directpath initialization mode - #16391

Merged
scotthart merged 2 commits into
googleapis:mainfrom
scotthart:bigtable_dp_init_mode_option
Aug 27, 2026
Merged

impl(bigtable): add option to select directpath initialization mode#16391
scotthart merged 2 commits into
googleapis:mainfrom
scotthart:bigtable_dp_init_mode_option

Conversation

@scotthart

Copy link
Copy Markdown
Member

No description provided.

@scotthart
scotthart requested a review from a team as a code owner August 27, 2026 16:05
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Aug 27, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces DirectPathInitializationModeOption to allow configuring the initialization behavior of DirectPath in Google Cloud Bigtable, supporting both blocking and speculative asynchronous modes. The feedback suggests refactoring MakeBlockingDirectPathDataConnection to eliminate duplicated StubManager creation logic using a helper lambda, and optimizing MakeDirectPathDataConnection to avoid unnecessary copies of components.options while preventing potential order-of-evaluation issues.

Comment thread google/cloud/bigtable/data_connection.cc
Comment thread google/cloud/bigtable/data_connection.cc
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.45133% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.26%. Comparing base (17ad4f5) to head (8b3a906).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...d/bigtable/tests/observability_integration_test.cc 42.42% 19 Missing ⚠️
google/cloud/bigtable/data_connection.cc 81.03% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16391      +/-   ##
==========================================
+ Coverage   92.24%   92.26%   +0.01%     
==========================================
  Files        2246     2246              
  Lines      212035   212121      +86     
==========================================
+ Hits       195598   195710     +112     
+ Misses      16437    16411      -26     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart
scotthart merged commit 48eeb77 into googleapis:main Aug 27, 2026
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants