impl(bigtable): add DirectPath diagnostics - #16378
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces DirectPath diagnostics for Google Cloud Bigtable, adding the DirectPathDiagnostics class, associated network system interfaces, and unit tests. Key feedback highlights a critical bug where inet_pton failures could cause false positives by connecting to localhost, and another issue where the calculated timeout in RunAsync is unused and not captured by the lambda. Additionally, recommendations were made to optimize interface name comparisons using std::strcmp, pass std::shared_ptr arguments by const& to avoid atomic reference count overhead, and remove default parameters in the internal namespace to comply with the repository style guide.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16378 +/- ##
==========================================
+ Coverage 92.27% 92.29% +0.02%
==========================================
Files 2241 2244 +3
Lines 211219 211631 +412
==========================================
+ Hits 194904 195329 +425
+ Misses 16315 16302 -13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Adds diagnostics check for determining DirectPath status.