Skip to content

impl(bigtable): add DirectPath diagnostics - #16378

Merged
scotthart merged 3 commits into
googleapis:mainfrom
scotthart:bigtable_dp_diag
Aug 24, 2026
Merged

impl(bigtable): add DirectPath diagnostics#16378
scotthart merged 3 commits into
googleapis:mainfrom
scotthart:bigtable_dp_diag

Conversation

@scotthart

Copy link
Copy Markdown
Member

Adds diagnostics check for determining DirectPath status.

@scotthart
scotthart requested a review from a team as a code owner August 24, 2026 21:28
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Aug 24, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces DirectPath diagnostics for Google Cloud Bigtable, adding the DirectPathDiagnostics class, associated network system interfaces, and unit tests. Key feedback highlights a critical bug where inet_pton failures could cause false positives by connecting to localhost, and another issue where the calculated timeout in RunAsync is unused and not captured by the lambda. Additionally, recommendations were made to optimize interface name comparisons using std::strcmp, pass std::shared_ptr arguments by const& to avoid atomic reference count overhead, and remove default parameters in the internal namespace to comply with the repository style guide.

Comment thread google/cloud/bigtable/internal/directpath_diagnostics.cc Outdated
Comment thread google/cloud/bigtable/internal/directpath_diagnostics.cc Outdated
Comment thread google/cloud/bigtable/internal/directpath_diagnostics.cc Outdated
Comment thread google/cloud/bigtable/internal/directpath_diagnostics.h Outdated
Comment thread google/cloud/bigtable/internal/directpath_diagnostics.h
@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.84466% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.29%. Comparing base (f44759f) to head (db661d2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...d/bigtable/internal/directpath_diagnostics_test.cc 97.59% 7 Missing ⚠️
.../cloud/bigtable/internal/directpath_diagnostics.cc 95.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16378      +/-   ##
==========================================
+ Coverage   92.27%   92.29%   +0.02%     
==========================================
  Files        2241     2244       +3     
  Lines      211219   211631     +412     
==========================================
+ Hits       194904   195329     +425     
+ Misses      16315    16302      -13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart
scotthart merged commit fdfdbea into googleapis:main Aug 24, 2026
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants