Skip to content

impl(bigtable): add Directpath prober - #16376

Merged
scotthart merged 4 commits into
googleapis:mainfrom
scotthart:bigtable_dp_probe_diag
Aug 24, 2026
Merged

impl(bigtable): add Directpath prober#16376
scotthart merged 4 commits into
googleapis:mainfrom
scotthart:bigtable_dp_probe_diag

Conversation

@scotthart

Copy link
Copy Markdown
Member

Probes to see if a directpath connection is possible.

@scotthart
scotthart requested a review from a team as a code owner August 24, 2026 16:31
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Aug 24, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new DirectPathProber utility class and its corresponding unit tests to probe DirectPath startup compatibility, along with a new DirectPathProbeTimeoutOption configuration option. Feedback on the changes highlights a potential RPC failure if the required PingAndWarmRequest::name field is left empty, suggesting a fallback mechanism using project and instance ID options. Additionally, a style guide violation was noted regarding the use of absl::string_view instead of std::string_view.

Comment thread google/cloud/bigtable/internal/directpath_prober.cc Outdated
Comment thread google/cloud/bigtable/internal/directpath_prober.cc Outdated
@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.27047% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.27%. Comparing base (d2bb2bb) to head (57e1541).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../cloud/bigtable/internal/directpath_prober_test.cc 96.45% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16376      +/-   ##
==========================================
- Coverage   92.27%   92.27%   -0.01%     
==========================================
  Files        2239     2241       +2     
  Lines      210816   211219     +403     
==========================================
+ Hits       194537   194905     +368     
- Misses      16279    16314      +35     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart
scotthart marked this pull request as draft August 24, 2026 17:29
@scotthart
scotthart marked this pull request as ready for review August 24, 2026 17:47
@colinmoy

Copy link
Copy Markdown
Contributor

There seems to be missing test coverage for IsDirectPathIp and ExtractIpPreference

@scotthart
scotthart merged commit f44759f into googleapis:main Aug 24, 2026
73 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants