impl(bigtable): add Directpath prober - #16376
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new DirectPathProber utility class and its corresponding unit tests to probe DirectPath startup compatibility, along with a new DirectPathProbeTimeoutOption configuration option. Feedback on the changes highlights a potential RPC failure if the required PingAndWarmRequest::name field is left empty, suggesting a fallback mechanism using project and instance ID options. Additionally, a style guide violation was noted regarding the use of absl::string_view instead of std::string_view.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16376 +/- ##
==========================================
- Coverage 92.27% 92.27% -0.01%
==========================================
Files 2239 2241 +2
Lines 210816 211219 +403
==========================================
+ Hits 194537 194905 +368
- Misses 16279 16314 +35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
There seems to be missing test coverage for IsDirectPathIp and ExtractIpPreference |
Probes to see if a directpath connection is possible.