fix!: require minimum libcurl 8.7.1 to fix curl bug - #16375
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the minimum required version of libcurl from 7.74.0 to 8.7.1 across the repository, including updating documentation, Dockerfiles, and CMake configurations. Feedback on these changes suggests installing libnghttp2-devel in the Dockerfile to maintain HTTP/2 support when building curl from source, and using the standard find_package(CURL 8.7.1 REQUIRED) syntax in CMake files instead of manual version checks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16375 +/- ##
==========================================
- Coverage 92.26% 92.25% -0.01%
==========================================
Files 2239 2239
Lines 210719 210719
==========================================
- Hits 194412 194406 -6
- Misses 16307 16313 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| ### Dependency version update | ||
|
|
||
| - Updated minimum version of libcurl from 7.74.0 to 8.7.1. This was done primarily to avoid a known bug introduced in libcurl 8.5.0. For more information, see [Issue #16343](https://github.com/googleapis/google-cloud-cpp/issues/16343). |
There was a problem hiding this comment.
One caveat on the phrase introduced in libcurl 8.5.0:
I mentioned libcurl 8.5.0 because it is the version we use. I'm not sure which version introduced this bug.
4 participants
Previous versions of libcurl contained a bug in curl_retry_request.
fixes #16343