chore: update markdown files disallowing internal default params - #16373
Merged
scotthart merged 1 commit intoAug 24, 2026
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the .agents/AGENTS.md file to add a new guideline discouraging the use of default arguments in internal namespaces. It explains that default parameters obscure dependencies and can mask untested branches in unit tests, recommending explicit overloads instead. There are no review comments to address, and I have no additional feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16373 +/- ##
==========================================
- Coverage 92.26% 92.25% -0.01%
==========================================
Files 2239 2239
Lines 210719 210719
==========================================
- Hits 194412 194406 -6
- Misses 16307 16313 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dbolduc
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update and/or emphasize that internal functions should not have default parameters.