Skip to content

chore: update markdown files disallowing internal default params - #16373

Merged
scotthart merged 1 commit into
googleapis:mainfrom
scotthart:gemini_internal_default_params
Aug 24, 2026
Merged

chore: update markdown files disallowing internal default params#16373
scotthart merged 1 commit into
googleapis:mainfrom
scotthart:gemini_internal_default_params

Conversation

@scotthart

Copy link
Copy Markdown
Member

Update and/or emphasize that internal functions should not have default parameters.

@scotthart
scotthart requested a review from a team as a code owner August 24, 2026 14:01

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .agents/AGENTS.md file to add a new guideline discouraging the use of default arguments in internal namespaces. It explains that default parameters obscure dependencies and can mask untested branches in unit tests, recommending explicit overloads instead. There are no review comments to address, and I have no additional feedback to provide.

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (30817a8) to head (a51b8f1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16373      +/-   ##
==========================================
- Coverage   92.26%   92.25%   -0.01%     
==========================================
  Files        2239     2239              
  Lines      210719   210719              
==========================================
- Hits       194412   194406       -6     
- Misses      16307    16313       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart
scotthart merged commit 6339afd into googleapis:main Aug 24, 2026
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants