Skip to content

chore(bigtable): fix some formatting and auto issues - #16369

Merged
scotthart merged 3 commits into
googleapis:mainfrom
scotthart:bigtable_formatting_cleanup
Aug 22, 2026
Merged

chore(bigtable): fix some formatting and auto issues#16369
scotthart merged 3 commits into
googleapis:mainfrom
scotthart:bigtable_formatting_cleanup

Conversation

@scotthart

Copy link
Copy Markdown
Member

Cleans up some full explicit namespace usage where it wasn't needed as well as switching some uses of auto to explicit types.

@scotthart
scotthart requested a review from a team as a code owner August 22, 2026 17:44
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Aug 22, 2026
@scotthart
scotthart enabled auto-merge (squash) August 22, 2026 17:44

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies namespace usage in the BigtableRandomTwoLeastUsed decorator by removing redundant google::cloud:: prefixes and updates stub_manager_test.cc to use explicit OperationContext& types instead of auto const& in lambda parameters. The review feedback suggests using void() instead of void(void) for empty parameter lists to align with the Google C++ style guide, and passing std::function parameters by const& instead of by value in helper functions to avoid unnecessary copy overhead.

Comment thread google/cloud/bigtable/internal/bigtable_random_two_least_used_decorator.cc Outdated
Comment thread google/cloud/bigtable/internal/bigtable_random_two_least_used_decorator.cc Outdated
Comment thread google/cloud/bigtable/internal/bigtable_random_two_least_used_decorator.cc Outdated
Comment thread google/cloud/bigtable/internal/bigtable_random_two_least_used_decorator.cc Outdated
@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (5a449d9) to head (b86c2dc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16369      +/-   ##
==========================================
- Coverage   92.27%   92.25%   -0.02%     
==========================================
  Files        2239     2239              
  Lines      210719   210719              
==========================================
- Hits       194444   194406      -38     
- Misses      16275    16313      +38     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart
scotthart merged commit 30817a8 into googleapis:main Aug 22, 2026
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants