Skip to content

feat(generator): automate compute discovery document updates - #16368

Merged
colinmoy merged 6 commits into
googleapis:mainfrom
colinmoy:feat-automate-compute-discovery
Aug 24, 2026
Merged

feat(generator): automate compute discovery document updates#16368
colinmoy merged 6 commits into
googleapis:mainfrom
colinmoy:feat-automate-compute-discovery

Conversation

@colinmoy

Copy link
Copy Markdown
Contributor

No description provided.

@colinmoy
colinmoy requested a review from a team as a code owner August 21, 2026 20:00

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the update_discovery_doc.sh script to download the discovery document to a temporary file and compare its revision with the current one before overwriting, avoiding unnecessary updates. The review feedback recommends adding explicit error checks for the mktemp and curl commands to ensure the script fails loudly and gracefully if these operations fail.

Comment thread generator/discovery/update_discovery_doc.sh Outdated
colinmoy and others added 3 commits August 21, 2026 13:03
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (5a449d9) to head (9234e5b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16368      +/-   ##
==========================================
- Coverage   92.27%   92.25%   -0.02%     
==========================================
  Files        2239     2239              
  Lines      210719   210719              
==========================================
- Hits       194444   194403      -41     
- Misses      16275    16316      +41     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@colinmoy
colinmoy merged commit cefdd50 into googleapis:main Aug 24, 2026
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants