feat(generator): automate compute discovery document updates - #16368
Merged
colinmoy merged 6 commits intoAug 24, 2026
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the update_discovery_doc.sh script to download the discovery document to a temporary file and compare its revision with the current one before overwriting, avoiding unnecessary updates. The review feedback recommends adding explicit error checks for the mktemp and curl commands to ensure the script fails loudly and gracefully if these operations fail.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16368 +/- ##
==========================================
- Coverage 92.27% 92.25% -0.02%
==========================================
Files 2239 2239
Lines 210719 210719
==========================================
- Hits 194444 194403 -41
- Misses 16275 16316 +41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
scotthart
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.