docs: fix ADC specific-JSON-key example in README#679
Open
SNO7E-G wants to merge 1 commit into
Open
Conversation
The "Call using a specific JSON key" snippet did not parse: - trailing comma after the first ServiceAccountCredentials assignment - $scope used in the match arms where the defined variable is $scopes - missing imports for ServiceAccountCredentials, UserRefreshCredentials and FetchAuthTokenCache
Hectorhammett
approved these changes
Jul 24, 2026
Contributor
|
This looks good to me! Thanks for the contribution! Can you take a look @bshaffer ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Call using a specific JSON key" example in the README does not parse and can't be
copy-pasted as-is. This fixes three issues in that snippet:
,) instead of a semicolon after the firstnew ServiceAccountCredentials(...)assignment — a parse error.matcharms reference$scope, but the variable defined above is$scopes.useimports forServiceAccountCredentials,UserRefreshCredentials, andFetchAuthTokenCache.Documentation only — no code or behavior changes. Verified the corrected snippet with
php -l.