Support unary builtins in DSLX map IR conversion. - #5085
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_992449708
branch
from
October 2, 2026 20:56
599cb31 to
628e4d5
Compare
`FunctionConverter::DefMapWithBuiltin` previously only handled `clz` and `ctz`, failing with an `Invalid builtin name for map` internal error during IR conversion when mapping other unary builtins that are already supported by the DSLX typechecker and bytecode interpreter. Extend `DefMapWithBuiltin` to synthesize wrapper IR functions for `and_reduce`, `or_reduce`, `xor_reduce`, `rev`, and `encode`. PiperOrigin-RevId: 992538071
copybara-service
Bot
force-pushed
the
test_992449708
branch
from
October 2, 2026 21:31
628e4d5 to
a386771
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support unary builtins in DSLX map IR conversion.
FunctionConverter::DefMapWithBuiltinpreviously only handledclzandctz, failing with anInvalid builtin name for mapinternal error during IR conversion when mapping other unary builtins that are already supported by the DSLX typechecker and bytecode interpreter.Extend
DefMapWithBuiltinto synthesize wrapper IR functions forand_reduce,or_reduce,xor_reduce,rev, andencode.