weight-sync(controller): fail-loud full source/destination coverage guard - #667
Open
lokic233 wants to merge 1 commit into
Open
weight-sync(controller): fail-loud full source/destination coverage guard#667lokic233 wants to merge 1 commit into
lokic233 wants to merge 1 commit into
Conversation
…uard
Full-state weight publication requires every registered destination variable to
have a matching source variable. Previously a destination var with no matching
source was SILENTLY left stale (dst={w0,w1}, src={w0} -> w0 lands, w1 keeps its
pre-transfer value, success=True, no raise) — a partial policy published as if
complete (BUG2 class).
Add a name-coverage check in controller plan-generation: before emitting the
transfer plan, raise if any registered destination variable has no source var by
name. Fail-loud rather than publish a partial policy.
Deterministically validated: raises on the missing-var repro (dst w1 unmatched),
passes on full coverage, skips None-named vars, no-op on empty dst. SCOPE: this
catches the missing-var (BUG2) class; it does NOT catch the silent byte-drop of a
PRESENT rank-1 var (that is the separate D2H event-completion fix). A per-byte
coverage tally is a documented follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Full-state weight publication requires every registered destination variable to have a matching source variable. Previously a destination var with no matching source was silently left stale — e.g. dst
{w0, w1}, src{w0}→w0lands,w1keeps its pre-transfer value,success == true, no raise. A partial policy is published as if complete (BUG2 class).Fix (fail-loud coverage check)
In controller plan-generation, before emitting the transfer plan, raise if any registered destination variable has no source variable by name. Fail-loud rather than publish a partial policy. The guard sits at the plan-entry point (the chunk-emission region edited by later commits is below it), so it composes cleanly.
Validation
Deterministic unit checks: raises on the missing-var repro (
w1unmatched), passes on full coverage, skipsNone-named vars, no-op on empty destination. Consistent with the LANDING full-state contract.Scope / non-goals
Catches the missing-var (BUG2) class. It does not catch the silent byte-drop of a present rank-1 var (that is the separate D2H event-completion fix). A per-byte/slice coverage tally is a documented follow-up. Not subset-sync (no stop-condition/partial-set semantics).
Authored with agentic assistance (Navi); guard logic validated deterministically and consistent with prior silicon runs.