Skip to content

[dashboard] Restore vertical spacing between bot rows #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitalybuka merged 2 commits into from
Oct 8, 2026
Merged

[dashboard] Restore vertical spacing between bot rows #1902

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d56ccd1
[dashboard] Restore vertical spacing between bot rows
vitalybuka Oct 8, 2026
c7c7f4b
[dashboard] Limit -render by commit count instead of builds
vitalybuka Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 10 additions & 23 deletions dashboard/dashboard.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
var (
cacheDir = flag.String("cache_dir", filepath.Join(os.TempDir(), "sanitizer-dashboard"), "Directory for caches and git checkout")
fetchLimit = flag.Int("fetch", 10, "Number of builds to fetch per bot")
renderLimit = flag.Int("render", 30, "Number of builds to render per bot")
renderLimit = flag.Int("render", 300, "Number of commits to render")

bots = []string{
"sanitizer-windows",
Expand Down Expand Up @@ -525,11 +525,9 @@ td.timeline > .missing:nth-child(even) { opacity: 0.5; }
table {
width: 100%;
flex-shrink: 0;
border-collapse: collapse;
}
td { white-space: nowrap; padding: 0 0.6em 0 0; font-size: 18px; line-height: 20px; text-align: right; }
td:nth-child(2) { font-size: 14px; }
td.timeline { width: 100%; max-width: 0; overflow: hidden; padding-right: 0; font-size: 24px; line-height: 20px; text-align: left; }
td { white-space: nowrap; padding-right: 0.6em; font-size: 18px; text-align: right; }
td.timeline { width: 100%; max-width: 0; overflow: hidden; padding-right: 0; font-size: 24px; text-align: left; }
</style>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js"></script>
<script>
Expand Down Expand Up @@ -606,20 +604,9 @@ $(document).on('mouseenter', 'td.timeline > .missing', function() {
saveCache(cachePath, cache)
commitList, commits := fetchCommits(filepath.Join(*cacheDir, "llvm-project.git"))

maxDist := 0
for i := range bots {
if !statuses[i].Lastbuild.IsZero() && time.Since(statuses[i].Lastbuild) > 7*24*time.Hour {
continue
}
displayStatuses := statuses[i].Statuses
if len(displayStatuses) > *renderLimit {
displayStatuses = displayStatuses[:*renderLimit]
}
for _, s := range displayStatuses {
if d, ok := commits[s.Revision]; ok && d > maxDist {
maxDist = d
}
}
maxDist := *renderLimit
if len(commitList) < maxDist {
maxDist = len(commitList)
}

tr := func(s string) string {
Expand All @@ -638,10 +625,10 @@ $(document).on('mouseenter', 'td.timeline > .missing', function() {
return fmt.Sprintf("<a href=\"%s\" target=_top>%s</a>", url, text)
}

if len(commitList) > 0 {
if maxDist > 0 {
googleColors := []string{"c0", "c1", "c2", "c0", "c3", "c1"}
var header strings.Builder
for d := 0; d <= maxDist && d < len(commitList); d++ {
for d := 0; d < maxDist; d++ {
c := commitList[d]
short := c.Hash
if len(short) > 7 {
Expand Down Expand Up @@ -708,7 +695,7 @@ $(document).on('mouseenter', 'td.timeline > .missing', function() {
byDist := make(map[int]status, len(statuses[i].Statuses))
for _, s := range statuses[i].Statuses {
d, ok := commits[s.Revision]
if !ok || d > maxDist {
if !ok || d >= maxDist {
continue
}
if _, exists := byDist[d]; !exists {
Expand All @@ -717,7 +704,7 @@ $(document).on('mouseenter', 'td.timeline > .missing', function() {
}
var timeline strings.Builder
style := ""
for d := 0; d <= maxDist; d++ {
for d := 0; d < maxDist; d++ {
if s, ok := byDist[d]; ok {
style = class(s)
fmt.Fprintf(&timeline, "<a href=\"%s\" target=_top title=\"%s (-%d)\">%s</a>",
Expand Down
Loading