Skip to content

🧪 Add tests for getUserInputPrefix helper#271

Draft
tushuhei wants to merge 1 commit into
mainfrom
improve-testing-get-user-input-prefix-4637760691737969135
Draft

🧪 Add tests for getUserInputPrefix helper#271
tushuhei wants to merge 1 commit into
mainfrom
improve-testing-get-user-input-prefix-4637760691737969135

Conversation

@tushuhei

Copy link
Copy Markdown
Member

This PR adds unit tests for the getUserInputPrefix helper function in src/pv-app.ts. This function uses a regex to filter keyboard-inputtable characters (Latin letters, Hiragana, spaces, and long vowel marks).

The new tests cover:

  • Standard Latin input.
  • Hiragana input with spaces and long vowel marks ().
  • Empty string edge case.
  • Boundary cases where the function stops at disallowed characters (Numbers, Katakana, and Symbols).

Additionally, some minor linting and formatting issues were fixed to ensure a clean build.


PR created automatically by Jules for task 4637760691737969135 started by @tushuhei

- Added test cases for empty string, mixed allowed characters, and various disallowed characters.
- Fixed minor lint errors across the codebase.

Co-authored-by: tushuhei <734905+tushuhei@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant