Skip to content

ui: Fix duplicate GPU frequency track URIs across multiple traces - #8545

Open
dreveman wants to merge 1 commit into
mainfrom
dev/dreveman/gpu-fix
Open

dreveman wants to merge 1 commit into
mainfrom
dev/dreveman/gpu-fix

Conversation

@dreveman

@dreveman dreveman commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Include the track ID in GPU frequency track URIs (/gpu_frequency_${ugpu}${id}), matching how addCounters (/counter${ugpu}${trackId}) and addSlices (/slice${ugpu}_${trackId}) construct URIs.

In TraceProcessorContext, GpuTracker is per-machine while TrackTracker is per-trace-file, so opening multiple trace files that emit gpufreq events on the same machine produces multiple gpu_counter_track rows sharing the same ugpu.

Include the track ID in GPU frequency track URIs (/gpu_frequency_${ugpu}_${id}),
matching how addCounters (/counter_${ugpu}_${trackId}) and addSlices
(/slice_${ugpu}_${trackId}) construct URIs.

In TraceProcessorContext, GpuTracker is per-machine while TrackTracker is
per-trace-file, so opening multiple trace files that emit gpufreq events on the
same machine produces multiple gpu_counter_track rows sharing the same ugpu.
@dreveman
dreveman requested a review from LalitMaganti November 6, 2026 00:50
@LalitMaganti

Copy link
Copy Markdown
Member

This is actually explicitly unsupported at the moment and @ArpitKhatri5 is working through this (there's an other PR which makes this a hard error)

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

🎨 Perfetto UI Builds & Tests

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants