Repository navigation
perfetto: Enable TraceBufferV3 in the tracing service - #7908
Open
sashwinbalaji wants to merge 1 commit into
Open
sashwinbalaji wants to merge 1 commit into
sashwinbalaji wants to merge 1 commit into
Conversation
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/06-tbv3-service
branch
from
October 14, 2026 10:26
c77801b to
4bc0ad7
Compare
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/06-tbv3-service
branch
from
October 14, 2026 11:47
4bc0ad7 to
8979b9f
Compare
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/06-tbv3-service
branch
from
October 14, 2026 12:04
8979b9f to
5e3ebe2
Compare
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/06-tbv3-service
branch
3 times, most recently
from
October 15, 2026 16:01
ebd5a9e to
cdb6b2f
Compare
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/06-tbv3-service
branch
from
October 22, 2026 15:57
cdb6b2f to
d18a9e9
Compare
sashwinbalaji
changed the title
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/06-tbv3-service
branch
2 times, most recently
from
October 22, 2026 17:55
437d021 to
276a6ab
Compare
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/06-tbv3-service
branch
from
October 26, 2026 00:18
276a6ab to
266856d
Compare
sashwinbalaji
marked this pull request as ready for review
October 26, 2026 00:22
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/06-tbv3-service
branch
from
October 26, 2026 11:46
266856d to
6afae67
Compare
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/06-tbv3-service
branch
from
October 29, 2026 18:30
6afae67 to
00c56ca
Compare
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/06-tbv3-service
branch
from
November 4, 2026 11:25
00c56ca to
e7200dd
Compare
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/06-tbv3-service
branch
from
November 5, 2026 09:40
e7200dd to
b28a64c
Compare
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/06-tbv3-service
branch
7 times, most recently
from
November 5, 2026 22:28
63fd408 to
c150381
Compare
A trace config can now use TraceBufferV3 with buffer_type.v3. - Builds without zstd skip it and use the next listed type. - All TraceBufferV3s of a service share one zstd codec, which is freed with the last of them. - The memory guardrail counts that codec once. The service tells buffers when a write batch is complete. - At a batch's end, TraceBufferV3 bundles once staging holds its target, so a checkpoint pass doesn't split a batch. - A batch is a CommitData request, an SMB v2 drain pass or an SMB v1 scrape. - The SMB v2 drain retry moves from the drainer to the producer endpoint, so the endpoint can notify after each pass. Shared memory emulation is not supported yet. - One batch can be split across several CommitData requests. - So the service does not start an emulated producer's data source on a V3 buffer, and drops chunks sent inline to one. A TODO notes where the service can replace loss bits when it reads packets.
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/06-tbv3-service
branch
from
November 5, 2026 22:50
c150381 to
071f328
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A trace config can now use TraceBufferV3 with buffer_type.v3.
with the last of them.
The service tells buffers when a write batch is complete.
target, so a checkpoint pass doesn't split a batch.
scrape.
endpoint, so the endpoint can notify after each pass.
Shared memory emulation is not supported yet.
on a V3 buffer, and drops chunks sent inline to one.
A TODO notes where the service can replace loss bits when it reads
packets.