Skip to content

fix: use --output-file instead of --output #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
G-Rath wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: use --output-file instead of --output #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05147f9
fix: use `--output-file` instead of `--output`
G-Rath Mar 10, 2026
cc9084f
fix: use `--output-file` instead of `--output`
G-Rath Mar 10, 2026
9bd8ad2
chore: update comment
G-Rath Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/osv-scanner-reusable-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ on:
workflow_call:
inputs:
scan-args:
description: "Custom osv-scanner arguments (See https://google.github.io/osv-scanner/usage/ for options, you cannot set --format or --output)"
description: "Custom osv-scanner arguments (See https://google.github.io/osv-scanner/usage/ for options, you cannot set --format or --output-file)"
type: string
default: |-
-r
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
with:
scan-args: |-
--format=json
--output=${{ inputs.matrix-property }}old-results.json
--output-file=${{ inputs.matrix-property }}old-results.json
${{ inputs.scan-args }}
- name: "Checkout current branch"
# Use -f in case any changes were made by osv-scanner (there should be no changes)
Expand All @@ -83,14 +83,14 @@ jobs:
with:
scan-args: |-
--format=json
--output=${{ inputs.matrix-property }}new-results.json
--output-file=${{ inputs.matrix-property }}new-results.json
${{ inputs.scan-args }}
continue-on-error: true
- name: "Run osv-scanner-reporter"
uses: google/osv-scanner-action/osv-reporter-action@8018483926dd235b3013d8c88023e644b9f8e09e # v2.3.3
with:
scan-args: |-
--output=${{ inputs.matrix-property }}${{ inputs.results-file-name }}
--output-file=${{ inputs.matrix-property }}${{ inputs.results-file-name }}

@IchordeDionysos IchordeDionysos Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In osv-reporter this is different, this also replaces the deprecated --gh-annotations=true:

Suggested change
--output-file=${{ inputs.matrix-property }}${{ inputs.results-file-name }}
--output-file=json:${{ inputs.matrix-property }}${{ inputs.results-file-name }},gh-annotations:#stderr

--old=${{ inputs.matrix-property }}old-results.json
--new=${{ inputs.matrix-property }}new-results.json
--gh-annotations=true

@IchordeDionysos IchordeDionysos Aug 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--gh-annotations=true

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/osv-scanner-reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ on:
workflow_call:
inputs:
scan-args:
description: "Custom osv-scanner arguments (See https://google.github.io/osv-scanner/usage/ for options, you cannot set --format or --output)"
description: "Custom osv-scanner arguments (See https://google.github.io/osv-scanner/usage/ for options, you cannot set --format or --output-file)"
type: string
default: |-
-r
Expand Down Expand Up @@ -80,15 +80,15 @@ jobs:
uses: google/osv-scanner-action/osv-scanner-action@8018483926dd235b3013d8c88023e644b9f8e09e # v2.3.3
with:
scan-args: |-
--output=${{ inputs.matrix-property }}results.json
--output-file=${{ inputs.matrix-property }}results.json
--format=json
${{ inputs.scan-args }}
continue-on-error: true
- name: "Run osv-scanner-reporter"
uses: google/osv-scanner-action/osv-reporter-action@8018483926dd235b3013d8c88023e644b9f8e09e # v2.3.3
with:
scan-args: |-
--output=${{ inputs.matrix-property }}${{ inputs.results-file-name }}
--output-file=${{ inputs.matrix-property }}${{ inputs.results-file-name }}

@IchordeDionysos IchordeDionysos Aug 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--output-file=${{ inputs.matrix-property }}${{ inputs.results-file-name }}
--output-file=sarif:${{ inputs.matrix-property }}${{ inputs.results-file-name }}

--new=${{ inputs.matrix-property }}results.json
--gh-annotations=false

@IchordeDionysos IchordeDionysos Aug 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--gh-annotations=false

--fail-on-vuln=${{ inputs.fail-on-vuln }}
Expand Down