skia: fix build - #16094
Merged
Merged
Conversation
Signed-off-by: David Korczynski <david@adalogics.com>
Collaborator
Author
|
@kjlubick could you help review this one? For reference, this came following some debug in other efforts of trying to fix Skia: #16084 (comment) |
Contributor
|
LGTM |
AdamKorcz
approved these changes
Sep 2, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skia already intends to disable the shim under sanitizers (build_overrides/partition_alloc.gni: "Sanitizers replace the allocator, don't replace it ourselves"), but that guard tests the sanitize GN arg, which OSS-Fuzz never sets — it passes -fsanitize= via extra_cflags. The flag forces the outcome Skia already wanted