infra: avoid excessive objdump calls and adjust all.sh - #16083
Merged
Conversation
We're currently doing excessive objdump calls in the bad build check. We only need it once to calculate the sanitizer keywords. Also adjust all.sh so it's no longer needed to set up specific Python packages to build the base images. This also makes it very easy to quickly adjust which base images to build by modifying the file. This is how it was earlier which IMO works better when adjusting the base images. Signed-off-by: David Korczynski <david@adalogics.com>
Contributor
|
/gcbrun |
Collaborator
Author
|
/gcbrun trial_build.py htslib json-c javacpp jansson janet --fuzzing-engines libfuzzer --sanitizers address |
DavidKorczynski
referenced
this pull request
Sep 1, 2026
Updates LLVM usage to match [6d1ace547c9f](llvm/llvm-project@6d1ace547c9f) Indexer-PiperOrigin-RevId: 956634975
Collaborator
Author
|
The trial run failed because the indexer is pushed out of sync with our llvm version. See 0f4d4d3#commitcomment-198554014 Consequently, no projects were build.
|
Signed-off-by: David Korczynski <david@adalogics.com>
Collaborator
Author
|
/gcbrun trial_build.py htslib json-c javacpp jansson janet --fuzzing-engines libfuzzer --sanitizers address |
Collaborator
Author
|
The above succeeded: |
Collaborator
Author
|
/gcbrun trial_build.py binutils boringssl bzip2 c-blosc ghostscript openssl giflib haproxy gstreamer libpng ffmpeg libjxl libavc muduo muparser --fuzzing-engines libfuzzer --sanitizers address |
ViniciustCosta
approved these changes
Sep 1, 2026
DavidKorczynski
referenced
this pull request
Sep 2, 2026
Updates LLVM usage to match [cbc5a226cbf8](llvm/llvm-project@cbc5a226cbf8) Indexer-PiperOrigin-RevId: 974715562
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're currently doing excessive objdump calls in the bad build check. We only need it once to calculate the sanitizer keywords.
Also adjust all.sh so it's no longer needed to set up specific Python packages to build the base images. This also makes it very easy to quickly adjust which base images to build by modifying the file. This is how it was earlier which IMO works better when adjusting the base images.