Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigDict.to_json_best_effort()is intended to serialize what it can without raising. However, a set such as{1, 'one'}or{None, 3}raisesTypeErrorbecause its elements cannot be sorted against each other. This can prevent an otherwise valid experiment configuration from being exported.This change keeps the existing sort for comparable elements and falls back to sorting by
reprwhen that raisesTypeError. The output still contains the original element values, not their string representations. No stable ordering is promised for arbitrary custom objects, and strictto_json()conversion is unchanged.Tests
pytest -q -n 2 ml_collections/ --ignore=ml_collections/config_dict/examples/examples_test.py— 393 passed, 1 skipped.git diff --checkpass.The Windows core run retains one
testFlagfilefailure that also occurs on the unmodified base; the Linux runs above pass. The other Linux Python versions in CI were not run locally.