Repository navigation
fix: assign mutable sequence slices in config paths - #78
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config_path.splitandget_valuesupport slice paths, butset_value('data[1:3]', {'data': [...]}, replacement)raisesKeyError: its mutable-sequence assignment branch handles integers only and falls through to a membership check for slices.Handle slices alongside integer indices for mutable sequences, delegating replacement and extended-slice validation to the sequence itself. Tests cover bounded, whole, stepped, and negative slices, plus an invalid extended-slice replacement.
Validation: all five regressions fail before the change. Config-dict and config-flags suites: 390 passed, 8 subtests passed, 1 skipped, 1 deselected. The deselected
testFlagfilefails identically on unchanged upstream on Windows because its test command strips backslashes from the temporary path.git diff --checkpasses.