Add validate_flag to incremental_outcome and propagate across loop iterations#1696
Open
copybara-service[bot] wants to merge 1 commit into
Open
Add validate_flag to incremental_outcome and propagate across loop iterations#1696copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…erations Allows callers like optimizer._create_grids and analyzer.response_curves_grid that invoke incremental_outcome inside tight loops to perform validation once before the loop and pass validate_flag=False on loop iterations, avoiding redundant counterfactual validation overhead. Tested: We tested this optimization, but it might not cover all test cases or usage scenarios. As this change is for open source, please review and test for your specific requirements before adoption. PiperOrigin-RevId: 945656999
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validate_flag to incremental_outcome and propagate across loop iterations
Allows callers like optimizer._create_grids and analyzer.response_curves_grid that invoke incremental_outcome inside tight loops to perform validation once before the loop and pass validate_flag=False on loop iterations, avoiding redundant counterfactual validation overhead.
Tested:
We tested this optimization, but it might not cover all test cases or usage scenarios. As this change is for open source, please review and test for your specific requirements before adoption.