Generate inputs0 conditionally in incremental_outcome to speed up grid generation.#1695
Open
copybara-service[bot] wants to merge 1 commit into
Open
Generate inputs0 conditionally in incremental_outcome to speed up grid generation.#1695copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_943373166
branch
from
3cf8137 to
2a4dd0a
Compare
…d generation. Generate the `inputs0` corresponding to `scaling_factor0` in the `incremental_outcome` method only when `scaling_factor0 != 0 or not all(media_selected_times)` to speed up the grid generation. Tested: We tested this optimization, but it might not cover all test cases or usage scenarios. As this change is for open source, please review and test for your specific requirements before adoption. PiperOrigin-RevId: 943373166
copybara-service
Bot
force-pushed
the
test_943373166
branch
from
2a4dd0a to
72059fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate inputs0 conditionally in incremental_outcome to speed up grid generation.
Generate the
inputs0corresponding toscaling_factor0in theincremental_outcomemethod only whenscaling_factor0 != 0 or not all(media_selected_times)to speed up the grid generation.Tested:
We tested this optimization, but it might not cover all test cases or usage scenarios. As this change is for open source, please review and test for your specific requirements before adoption.