Optimize time index resolution in tensors.py with $O(1)$ set lookups#1693
Open
copybara-service[bot] wants to merge 1 commit into
Open
Optimize time index resolution in tensors.py with $O(1)$ set lookups#1693copybara-service[bot] wants to merge 1 commit into
tensors.py with $O(1)$ set lookups#1693copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_941783042
branch
from
1e16c1e to
9a1aa91
Compare
- Convert string and coordinate collections to Python sets before membership checks in `_resolve_time_indices`, `_validate_selected_times`, and `build_counterfactual_inputs`. - Reduce time index resolution runtime from $O(N \times M)$ linear scans to $O(1)$ set lookups, speeding up counterfactual evaluation across optimization grid iterations. - Add DataArray string type conversions to prevent DataArray unhashability `TypeError` in xarray coordinate matching. Tested: We tested this optimization, but it might not cover all test cases or usage scenarios. As this change is for open source, please review and test for your specific requirements before adoption. PiperOrigin-RevId: 941783042
copybara-service
Bot
force-pushed
the
test_941783042
branch
from
9a1aa91 to
8c8505c
Compare
copybara-service
Bot
changed the title
tensors.py with $O(1)$ set lookups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize time index resolution in$O(1)$ set lookups
tensors.pywith_resolve_time_indices,_validate_selected_times, andbuild_counterfactual_inputs.TypeErrorin xarray coordinate matching.Tested:
We tested this optimization, but it might not cover all test cases or usage scenarios. As this change is for open source, please review and test for your specific requirements before adoption.