Make unexpected subprocess kills thread-safe. - #14592
Open
copybara-service[bot] wants to merge 1 commit into
Open
Make unexpected subprocess kills thread-safe.#14592copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test/cl975832029
branch
from
September 3, 2026 20:47
4d81826 to
3c80573
Compare
To kill the subprocess, we kill the syscall thread, which in turn kills all stub threads by virtue of being their parent. This means we have two critical sections that need to be protected: 1. Creating new sysmsg threads -- the function expects that it's new baby will stay alive at least while it's being created; 2. Using the syscall thread itself. We also kick out any currently sleeping task goroutines, and put guard-checks on wait loops and possible entrances to subprocess functionality so that tasks don't come back to a dead subprocess. Additionally, killed subprocesses were not properly decref'ed before, this CL also fixes that. PiperOrigin-RevId: 975832029
copybara-service
Bot
force-pushed
the
test/cl975832029
branch
from
September 3, 2026 22:01
3c80573 to
1a850d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make unexpected subprocess kills thread-safe.
To kill the subprocess, we kill the syscall thread, which in turn kills all
stub threads by virtue of being their parent. This means we have two critical
sections that need to be protected:
will stay alive at least while it's being created;
We also kick out any currently sleeping task goroutines, and put guard-checks
on wait loops and possible entrances to subprocess functionality so that tasks
don't come back to a dead subprocess.
Additionally, killed subprocesses were not properly decref'ed before, this CL
also fixes that.